魔法值替换成枚举

yanxuan-qc-change-system-biz/src/main/java/com/netease/mail/yanxuan/change/biz/service/impl/InteriorChangeConfigServiceImpl.java

@@ -6,6 +6,7 @@ import com.netease.mail.yanxuan.change.biz.service.InteriorChangeConfigService;
 import com.netease.mail.yanxuan.change.biz.service.change.ChangeConfigService;
 import com.netease.mail.yanxuan.change.common.bean.ResponseCode;
 import com.netease.mail.yanxuan.change.common.enums.ChangeCommanderEnum;
+import com.netease.mail.yanxuan.change.common.enums.ChangePrincipalEnum;
 import com.netease.mail.yanxuan.change.common.enums.ChangeSubjectEnum;
 import com.netease.mail.yanxuan.change.dal.entity.ChangeConfig;
 import com.netease.mail.yanxuan.change.dal.meta.model.po.ChangeCommanderPO;
@@ -20,6 +21,7 @@ import com.netease.mail.yanxuan.change.integration.flow.supplier.FlowRpcSupplier
 import com.netease.mail.yanxuan.change.integration.flow.supplier.req.SupplierRelatedUserReq;
 import com.netease.mail.yanxuan.change.integration.flow.supplier.rsp.SupplierUserRsp;
 import com.netease.yanxuan.flowx.sdk.meta.controller.communal.AjaxResponse;
+import org.apache.commons.collections4.CollectionUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -66,17 +68,19 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
         }
         //查询出当前模板配置中选择的 角色
         ChangeCommanderEnum changeCommanderEnum = ChangeCommanderEnum.getChangeCommanderEnum(changeConfig.getChangeCommanderType());
+        if (changeCommanderEnum == null){
+            return null;
+        }
         //直接排除 选项为固定人 或者发起人
-        if (changeCommanderEnum.getId() == 1 || changeCommanderEnum.getId() == 2){
+        if (changeConfig.getChangeCommanderType() == ChangeCommanderEnum.COMMANDER_ORIGINATOR.getId() || changeConfig.getChangeCommanderType() == ChangeCommanderEnum.FIXED_PERSON.getId() ){
             //固定人或者发起人;
             rpc.setEmail(changeConfig.getChangeCommander());
             return rpc;
         }
-        ChangeSubjectEnum changeSubjectEnum = ChangeSubjectEnum.getChangeSubjectEnum(changeConfig.getChangeSubject());
-        if (changeSubjectEnum.getType() == 1){
+        if (ChangeSubjectEnum.PRODUCT.getType() == changeConfig.getChangeSubject()){
             //商品变更
             return queryGoodsCommander(changeCommanderEnum,changeCommander.getGoodsInfos(),changeConfig.getChangeCommander());
-        }else if (changeSubjectEnum.getType() == 2){
+        }else if (ChangeSubjectEnum.SUPPLIER.getType() == changeConfig.getChangeSubject()){
             //供应商  采购 计划 SQE
             return queryChangeSupplier(changeCommanderEnum,changeCommander.getChangeSupplierId(),changeConfig.getChangeCommander());
         }
@@ -88,11 +92,11 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
      * 商品的最终角色查询
      * @param commanderEnum   查询方向 枚举
      * @param goodsInfos  商品的列表
-     * @param commander   商品的关联角色
+     * @param commander   商品的关联角色  ChangeCommanderEnum
      * @return
      */
     private GoodsResponseRpc queryGoodsCommander(ChangeCommanderEnum commanderEnum,List<Long> goodsInfos,String commander){
-        if (commanderEnum.getId() != 3 || goodsInfos == null || goodsInfos.size() == 0 || commander == null){
+        if (commanderEnum.getId() != ChangeCommanderEnum.GOODS_ASSOCIATED.getId() || CollectionUtils.isEmpty(goodsInfos) || commander == null){
             return null;
         }
         Map<String,GoodsResponseRpc> map = new HashMap<String,GoodsResponseRpc>();
@@ -103,11 +107,13 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
         //记录出现的所有值
         List<GoodsResponseRpc> emails = new ArrayList<GoodsResponseRpc>();
         //遍历取出所有商品关联的人
-        if (commander.equals("商品BU")) {
+
+        if (ChangePrincipalEnum.GOODS_BU.getName().equals(commander)) {
             String detail = itemcenterApiRpcService.getDetail(goodsInfos);
             logger.error("根据商品查看商品负责BU接口返回值\t"+detail);
             getGoodsNameEmail(emails,detail);
-        } else if (commander.equals("采购")) {
+
+        } else if (ChangePrincipalEnum.PURCHASE.getName().equals(commander)) {
             //采购返回值处理逻辑
             String detail = supplierSendService.queryGoodsPurchase(goodsInfos);
             logger.error("根据商品查看商品负责采购接口返回值\t"+detail);
@@ -119,11 +125,11 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
                 goodsRpc.setName(purchaseRpc.getSupplierName());
                 emails.add(goodsRpc);
             }
-        } else if (commander.equals("计划")) {
+        } else if (ChangePrincipalEnum.PROSPECTUS.getName().equals(commander)) {
             String detail = pfuApiRpcService.getDetail(goodsInfos);
             logger.error("根据商品查看商品负责计划接口返回值\t"+detail);
             getGoodsNameEmail(emails,detail);
-        } else if (commander.equals("SQE")) {
+        } else if (ChangePrincipalEnum.SQE.getName().equals(commander)) {
             for (Long goods:goodsInfos) {
                 String detail = qcApiRpcService.getDetail(goods.intValue());
                 logger.error("根据商品查看商品负责SQE接口返回值\t"+detail);
@@ -177,11 +183,11 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
         List<String> supplierIdList = new ArrayList<>();
         supplierIdList.add(changeSupplierId);
         //changeSupplier 根据提供的信息去查询 最终返回
-        if (commander.equals("采购")){
+        if (ChangePrincipalEnum.PURCHASE.getName().equals(commander)){
             req.setSearchType(1);
-        }else if (commander.equals("计划")){
+        }else if (ChangePrincipalEnum.PROSPECTUS.getName().equals(commander)){
             req.setSearchType(2);
-        }else if (commander.equals("SQE")){
+        }else if (ChangePrincipalEnum.SQE.getName().equals(commander)){
             req.setSearchType(3);
         }
         req.setSupplierIdList(supplierIdList);

yanxuan-qc-change-system-common/src/main/java/com/netease/mail/yanxuan/change/common/enums/ChangePrincipalEnum.java

+package com.netease.mail.yanxuan.change.common.enums;
+
+/**
+ * @author WangJiaXiang
+ * @date 2022/12/6/006$
+ */
+public enum ChangePrincipalEnum {
+
+    GOODS_BU(1,"商品BU"),
+    PURCHASE(2,"采购"),
+    PROSPECTUS(3,"计划"),
+    SQE(4,"SQE");
+
+
+    ChangePrincipalEnum(Integer type, String name) {
+        this.type = type;
+        this.name = name;
+    }
+
+    private Integer type;
+
+    private String name;
+
+    public Integer getType() {
+        return type;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+}