逻辑判断修改

yanxuan-qc-change-system-biz/src/main/java/com/netease/mail/yanxuan/change/biz/service/InteriorChangeConfigService.java

@@ -16,6 +16,6 @@ public interface InteriorChangeConfigService {
 
     GoodsResponseRpc queryCommanderInfo(ChangeCommanderPO changeCommander);
 
-    Map<Long, ChangeGoodsPrincipalPO>  queryGoodsPrincipalInfo(List<Long> itemIds);
+    Map<Long, ChangeGoodsPrincipalPO> queryGoodsPrincipalInfo(List<Long> itemIds);
 
 }

yanxuan-qc-change-system-biz/src/main/java/com/netease/mail/yanxuan/change/biz/service/impl/InteriorChangeConfigServiceImpl.java

@@ -218,6 +218,9 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
     @Override
     public Map<Long, ChangeGoodsPrincipalPO> queryGoodsPrincipalInfo(List<Long> itemIds){
         Map<Long, ChangeGoodsPrincipalPO> map = new HashMap<>();
+        for (Long itemId : itemIds){
+            map.put(itemId,new ChangeGoodsPrincipalPO());
+        }
         //商品BU
         String functionary = itemcenterApiRpcService.getDetail(itemIds);
         logger.error("请求商品BU结果"+functionary);
@@ -250,7 +253,7 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
     }
 
     /**
-     *
+     * 请求数据解析以及装载
      * @param type 1:BU  2:计划
      * @param map
      * @param response
@@ -262,12 +265,7 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
             throw ExceptionFactory.createBiz(ResponseCode.OPERATOR_NOT_EXIST);
         }
         for (String rpc : rpcMap.keySet()){
-            ChangeGoodsPrincipalPO goodsRpc;
-            if (map.containsKey(Long.parseLong(rpc))){
-                goodsRpc = map.get(Long.parseLong(rpc));
-            }else{
-                goodsRpc = new ChangeGoodsPrincipalPO();
-            }
+            ChangeGoodsPrincipalPO goodsRpc = map.get(Long.parseLong(rpc));
             if (type == 1){
                 goodsRpc.setFunctionaryName(rpcMap.get(rpc).get("uid").toString());
                 goodsRpc.setFunctionaryEmail(rpcMap.get(rpc).get("name").toString());
@@ -275,9 +273,6 @@ public class InteriorChangeConfigServiceImpl implements InteriorChangeConfigServ
                 goodsRpc.setGoodsProjectName(rpcMap.get(rpc).get("uid").toString());
                 goodsRpc.setGoodsProjectEmail(rpcMap.get(rpc).get("name").toString());
             }
-            if (!map.containsKey(Long.parseLong(rpc))){
-                map.put(Long.parseLong(rpc),goodsRpc);
-            }
         }
     }